[liblouis-liblouisxml] Re: Fix for the crash in lbu_checkTable
- From: "John J. Boyer" <john.boyer@xxxxxxxxxxxxxxxxx>
- To: liblouis-liblouisxml@xxxxxxxxxxxxx
- Date: Tue, 19 Jun 2012 06:45:14 -0500
Thanks. I'm sorry if I was impatient. I'm starting a new thread on the
logging functgigons.
John
On Tue, Jun 19, 2012 at 12:10:17PM +0100, Michael Whapples wrote:
> Yes, OK, fix it in liblouis, I probably would go with that anyway.
>
> Michael Whapples
> On 19/06/2012 12:02, John J. Boyer wrote:
> >I am working on a fix for the log functions in liblouis. A patch to
> >lbu_checktable would fix only one thing. I do not want it committed.
> >The fix to the logging functions is the right way to go.
> >
> >John
> >
> >On Tue, Jun 19, 2012 at 10:23:35AM +0100, Michael Whapples wrote:
> >>Hello,
> >>I have worked out a fix for the crash in lbu_checkTable and attach a
> >>patch. This fix means that NULL can be given for the log file and output
> >>will appear on STDERR.
> >>
> >>I would have committed this, but for some reason when I try and push I
> >>get a HTTP 404 error. So may be someone else could apply the patch.
> >>
> >>Also while on this topic, while I have corrected this in lbu_checkTable,
> >>the issue was that lou_logFile was being given a NULL, should
> >>lou_logFile be corrected so if NULL is given it will not crash?
> >>Alternatively, is it just seen to be wrong to give NULL to lou_logFile
> >>and so protecting it would not be worth while?
> >>
> >>Michael Whapples
> >
> >
>
>
> For a description of the software, to download it and links to
> project pages go to http://www.abilitiessoft.com
--
John J. Boyer; President, Chief Software Developer
Abilitiessoft, Inc.
http://www.abilitiessoft.com
Madison, Wisconsin USA
Developing software for people with disabilities
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
