Hi Christian, On 23/09/2014 7:30 PM, Christian Egli wrote:
With respect, I'm curious as to why this was merged in the first place. Obviously, contributions (particularly from new contributors) often aren't going to be perfect the first time; that's to be expected. However, IMO, nothing should make it into a branch from which releases are made until it is of acceptable quality, which the maintainers all seem to agree wasn't the case. Otherwise, potential bugs and other pollution creep into the codebase.The patch for the new indian languages contained really good stuff but also some things that were not really as good as we wished the contributions were (Sreeja and Dipendra, are you listening?). ... there are some duplications which it looks like I will have to fix.
I understand the desire to push things into releases so they get to users faster. However, liblouis is now on a quarterly release cycle, which is rapid enough that things will get to users within a more than reasonable time once they're ready. It's far better to work with contributors to get stuff into an acceptable state before merging than to merge it and then have to clean it up later. This way, there is a reasonable guarantee of quality for releases, rather than just a snapshot of whatever patches happened to be present at the time.
Of course, I'm aware that I'm not one of the maintainers, so this isn't my call to make. However, I'm curious as to the reasons for this merge and hope that I could offer some valuable feedback based on my experience with managing releases for NVDA.
Thanks, Jamie -- James Teh Executive Director, NV Access Limited Ph +61 7 3149 3306 www.nvaccess.org Facebook: http://www.facebook.com/NVAccess Twitter: @NVAccess SIP: jamie@xxxxxxxxxxxx For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com