[hipl-dev] Re: [hipl-commit] [trunk] Rev 4745: firewall: fix a signed/unsigned comparison

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Tue, 15 Jun 2010 12:29:17 +0200

On Wed, Jun 09, 2010 at 05:11:14PM +0300, Mircea Gherzan wrote:
> 
> --- firewall/midauth.c        2010-06-09 14:05:14 +0000
> +++ firewall/midauth.c        2010-06-09 14:10:57 +0000
> @@ -277,7 +277,7 @@
>  
> -    HIP_IFEL(len > sizeof(buffer), -1,
> +    HIP_IFEL(len > (int)sizeof(buffer), -1,

Note: K&R style places a space between the cast and the argument.

Diego

Other related posts:

  • » [hipl-dev] Re: [hipl-commit] [trunk] Rev 4745: firewall: fix a signed/unsigned comparison - Diego Biurrun