[hipl-dev] Re: [hipl-commit] [trunk] Rev 4718: heartbeat: mark unused parameters as such.
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Tue, 15 Jun 2010 12:19:29 +0200
On Tue, Jun 08, 2010 at 11:07:13PM +0300, Mircea Gherzan wrote:
>
> Log:
> heartbeat: mark unused parameters as such.
This is a lie, since ..
> --- modules/heartbeat/hipd/heartbeat.c 2010-05-31 09:44:40 +0000
> +++ modules/heartbeat/hipd/heartbeat.c 2010-06-08 20:06:12 +0000
> @@ -379,19 +380,10 @@
>
> - int err = 0;
> -
> -#if 0
> - heartbeat = hip_get_param(msg, HIP_PARAM_HEARTBEAT);
> - hip_icmp_interval = heartbeat->heartbeat;
> - heartbeat_counter = hip_icmp_interval;
> - HIP_DEBUG("Received heartbeat interval (%d seconds)\n",
> hip_icmp_interval);
> -#endif
> -
> - return err;
> + return 0;
.. you also remove unused code.
Diego
Other related posts:
- » [hipl-dev] Re: [hipl-commit] [trunk] Rev 4718: heartbeat: mark unused parameters as such. - Diego Biurrun
