[hipl-dev] Re: [hipl-commit] [trunk] Rev 4708: HITs in /etc/hosts fix

  • From: René Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Thu, 03 Jun 2010 17:29:09 +0200

I wonder if this actually needs to be fixed, as hit -> ip mapping should be 
derived from a combination of /etc/hip/hosts and /etc/hosts linked by the 
respective host name. Did you check whether hipd is still functional after this 
fix?

On Jun 3, 2010, at 12:29 PM, Artturi Karila wrote:
> Committer: Artturi Karila <artturi.karila@xxxxxxxxxx>
> Date: 03/06/2010 at 13:29:21
> Revision: 4708
> Revision-id: artturi.karila@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Branch nick: trunk
> 
> Log:
>  HITs in /etc/hosts fix
> 
>  Corrected hip_map_id_to_ip_from_hosts_files() to look for the HIT also in 
> /etc/hosts.
> 
> Modified:
>  M  lib/core/hostsfiles.c
> 
> === modified file 'lib/core/hostsfiles.c'
> --- lib/core/hostsfiles.c     2010-06-01 15:28:02 +0000
> +++ lib/core/hostsfiles.c     2010-06-03 10:29:21 +0000
> @@ -483,9 +483,12 @@
>     memset(hostname, 0, sizeof(hostname));
> 
>     if (hit && !ipv6_addr_any(hit)) {
> -        err = hip_for_each_hosts_file_line(HIPL_HOSTS_FILE,
> -                                           
> hip_map_first_id_to_hostname_from_hosts,
> -                                           hit, hostname);
> +        err = (hip_for_each_hosts_file_line(HIPL_HOSTS_FILE,
> +                                           
> hip_map_first_id_to_hostname_from_hosts,
> +                                           hit, hostname) &&
> +               hip_for_each_hosts_file_line(HOSTS_FILE,
> +                                           
> hip_map_first_id_to_hostname_from_hosts,
> +                                           hit, hostname));
>     } else {
>         struct in6_addr mapped_lsi;
>         IPV4_TO_IPV6_MAP(lsi, &mapped_lsi);




---
Dipl.-Inform. Rene Hummen, Ph.D. Student
Distributed Systems Group
RWTH Aachen University, Germany
tel: +49 241 80 20772
web: http://ds.rwth-aachen.de/members/hummen


Other related posts: