[hipl-dev] [Branch ~hipl-core/hipl/trunk] Rev 5237: Fixed on sync-all maintainer script
- From: noreply@xxxxxxxxxxxxx
- To: HIPL core team <hipl-dev@xxxxxxxxxxxxx>
- Date: Tue, 30 Nov 2010 21:57:34 -0000
------------------------------------------------------------
revno: 5237
committer: Miika Komu <miika@xxxxxx>
branch nick: trunk
timestamp: Tue 2010-11-30 23:54:35 +0200
message:
Fixed on sync-all maintainer script
According to suggestion from Diego:
- The ping is repeated, once for all hosts in succession, then for each
host before connecting to it. This seems pretty redundant to me.
- A temporary directory is created in a world-writable location, /tmp,
with a predictable name. This is a security hole. Does this need
explanation or am I preaching to the choir?
Removed also the unnecessary sudo.
modified:
tools/maintainer/sync-all
--
lp:hipl
https://code.launchpad.net/~hipl-core/hipl/trunk
Your team HIPL core team is subscribed to branch lp:hipl.
To unsubscribe from this branch go to
https://code.launchpad.net/~hipl-core/hipl/trunk/+edit-subscription
=== modified file 'tools/maintainer/sync-all'
--- tools/maintainer/sync-all 2010-11-30 21:01:59 +0000
+++ tools/maintainer/sync-all 2010-11-30 21:54:35 +0000
@@ -1,5 +1,7 @@
#!/bin/sh -xv
+TMP_DIR='~/.hipl.syncall.tmp.dir'
+
HOSTS="
halko.pc.infrahip.net
allerian.infrahipnet
@@ -14,8 +16,8 @@
"
COMMANDS="
-cd /tmp
-sudo rm -rf trunk
+cd $TMP_DIR
+rm -rf trunk
rm hipl.tar.gz
wget http://hipl.hiit.fi/hipl/hipl.tar.gz &&
tar xvzf hipl.tar.gz &&
@@ -58,7 +60,6 @@
time for HOST in $HOSTS; do
echo "--- Host: $HOST ---"
- ping -c 2 $HOST
if test $? = 0; then
ssh $HOST $COMMANDS
else
Other related posts:
