[hawkmoth] Re: [PATCH] parser: take into account clang diagnostics without a file

  • From: Jani Nikula <jani@xxxxxxxxxx>
  • To: Bruno Santos <brunomanuelsantos@xxxxxxxxxxxxxxxxxx>, hawkmoth@xxxxxxxxxxxxx
  • Date: Thu, 28 Jan 2021 10:07:48 +0200

On Wed, 27 Jan 2021, Bruno Santos <brunomanuelsantos@xxxxxxxxxxxxxxxxxx> wrote:

On 21:57:06 2021-01-25, Jani Nikula wrote:
Not all clang translation unit diagnostics are associated with a
file. For example, incorrect clang parameters have None for diagnostics
location. Handle them gracefully.

Fixes: #28

Hi Jani,

Sorry for the confusion with regards to where to review this. I didn't
notice that some separate threads were actually related and thought
these were all different things.

Perhaps we should just switch to a github merge request based workflow
to keep it all in one place and avoid confusion?

As mentioned, this one looks good to me ;)

Thanks, pushed.

BR,
Jani.

Other related posts:

  1. Home
  2. hawkmoth
  3. Archive
  4. 01-2021