[hawkmoth] Re: [PATCH] parser: take into account clang diagnostics without a file
- From: Bruno Santos <dmarc-noreply@xxxxxxxxxxxxx> (Redacted sender "brunomanuelsantos" for DMARC)
- To: hawkmoth@xxxxxxxxxxxxx
- Date: Thu, 28 Jan 2021 10:50:40 +0000
On 10:07:48 2021-01-28, Jani Nikula wrote:
On Wed, 27 Jan 2021, Bruno Santos <brunomanuelsantos@xxxxxxxxxxxxxxxxxx>
On 21:57:06 2021-01-25, Jani Nikula wrote:
Not all clang translation unit diagnostics are associated with a
file. For example, incorrect clang parameters have None for diagnostics
location. Handle them gracefully.
Sorry for the confusion with regards to where to review this. I didn't
notice that some separate threads were actually related and thought
these were all different things.
Perhaps we should just switch to a github merge request based workflow
to keep it all in one place and avoid confusion?
The confusion was totally on my side. But we can certainly give GitHub a
I will point out that we've experimented with GitLab's pull requests at
work not too long ago and it was a bit messy for us. The issue is how it
it's geared to track the end result only, not what happens over a long
series of commits. This is to say that it may go well initially with
small stories, but we may find it difficult to use for larger pull
requests. Some of the bigger issues with comment placement might have
been bugs though, we weren't entirely sure.
By the way, we still use GitLab at work, but not with pull requests.
It's more of an email like workflow with loose comments per commit,
which is what I couldn't find how to do in GitHub.
TLDR, let's see how it goes. 1st one was easy!
As mentioned, this one looks good to me ;)
Other related posts: