[haiku-gsoc] Re: SDL 1.3 Patch 00: Initial configuration changes
- From: "Ryan C. Gordon" <icculus@xxxxxxxxxxx>
- To: haiku-gsoc@xxxxxxxxxxxxx
- Date: Tue, 21 Jun 2011 17:31:56 -0400
On 6/21/11 5:16 PM, Nathan Heisey wrote:
Updated patch with only significant files attached.
Thank you, that's much better.
One more nitpick which has nothing to do with your actual work: keep the
commit messages simple. The etiquette is that the first line is a terse
overview, less than 80 characters, because it makes this view much more
useful:
http://hg.libsdl.org/SDL/shortlog
After that first line, you can put in any extra detail you want, but
it's redundant to say something like "Added appropriate checks in
configure.in" because the patch itself shows that.
The main SDL contributors still fail at this sometimes, but we try to
keep on top of it, since it's the permanent history of the project.
So I'd probably make the commit message "Implemented pthread spinlocks."
and leave it at that.
(do an "hg rollback" ... it'll remove the last commit from your clone
and leave the working copy as if you were about to commit it again.)
While we're all here: I'll be putting Nathan's patches into SDL's main
repo as the summer progresses, as soon as a Haiku developer says it's
okay. The pthread spinlock stuff isn't Haiku-specific, but there will be
platform-specific things I'd like the experts to sign off on.
--ryan.
Other related posts:
