[haiku-gsoc] Re: SDL 1.3 Patch 00: Initial configuration changes
- From: "Ryan C. Gordon" <icculus@xxxxxxxxxxx>
- To: haiku-gsoc@xxxxxxxxxxxxx
- Date: Tue, 21 Jun 2011 00:38:22 -0400
On 6/20/11 8:47 PM, Nathan Heisey wrote:
This patch provides an SDL spinlock implementation for Haiku.
The patch contains small changes to configure.in, SDL_configure.h.in,
and SDL_spinlock.c to add support for Haiku's implementation of
pthread spinlock.
Some notes:
- This was over 30,000 lines of changes to autogenerated files vs 71
lines of real changes. This is running out of a Mercurial clone, right?
It would be really useful if you committed your changes to your personal
clone, and then ran "hg export" ... this will spit out a patch, much
like now, but it will also include metadata so we can import specific
patches right into SDL's main repository while keeping your name on
them, etc. "hg record" is awesome, too, as you can quickly decide what
changes should actually be in a given commit (and decide quickly to skip
over files like "configure" without having to approve 30,000 lines of
changes). "hg pull --rebase" and "hg histedit" will probably save your
life, too.
- You can use single-line "//" comments in C++ code, which you'll
presumably be working in for the most part for Haiku-specific modules.
Please don't use them in .c files, though. For the most part, all
reasonable C compilers support them, but it makes it hard to bootstrap
SDL on strange, embedded platforms that might have crappy compilers.
- Use four spaces, not tabs for SDL 1.3. To make this more complicated,
SDL 1.2 used tabs. Sorry, we switched from one religion to another. :)
- pthread spinlocks aren't Haiku specific: you don't have to note that
this is for Haiku support in your comments. Presumably, we'll use it on
some other POSIX-like platform in the future.
--ryan.
Other related posts:
