[haiku-development] Re: Rename ControlLook constants, conflict

  • From: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 25 Oct 2017 19:50:50 +0200

On Wed, Oct 25, 2017 at 10:36:01AM -0700, John Scipione wrote:

These constants defined in ControlLook.h should be renamed as they
conflict with constants with the same name already defined in
InterfaceDefs.h. Right now ControlLook.h being in BPrivate namespace
means the conflict has not yet become detrimental, yet as we're
decided to break the ABI over ControlLook can we also please update
these constants?

B_LEFT_ARROW = 0,
B_RIGHT_ARROW = 1,
B_UP_ARROW = 2,
B_DOWN_ARROW = 3,

The enum is inside BControlLook. So, these constants are referred to as
BControlLook::B_LEFT_ARROW, etc. Thus they do not conflict with the ones
in InterfaceDefs and no renaming is needed.

-- 
Adrien.

Other related posts: