[haiku-development] Re: Rename ControlLook constants, conflict

  • From: looncraz <looncraz@xxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 25 Oct 2017 13:01:21 -0500

On 10/25/2017 12:57, John Scipione wrote:


The enum is inside BControlLook. So, these constants are referred to as
BControlLook::B_LEFT_ARROW, etc. Thus they do not conflict with the ones
in InterfaceDefs and no renaming is needed.
That isn't how any other B_* constant works anywhere else in the
system, I don't see why we would make this the exception. B_ constants
are typically in the default namespace and are unique.




+1

When I was going through the BControlLook code I found it odd. BControlLook::LEFT_ARROW would make more sense, IMHO.

Other related posts: