Hi there,
I've seen some of you have started doing code reviews on Gerrit, and
things seems to be going mostly well.
Don't hesitate to use the "score" when making a review. You have 5
possibilities:
- 0: no scoring
- -2: giving this score will prevent the change from being merged until
you change your scoring. As we usually put it here, "over my dead
body" (until you change the scoring, of course).
- +2: at least one +2 vote is required so a change can be merged. Use
wisely. (There is a Gerrit plugin that automates commiting when
someone gives a +2 and there are no -2, ideally we would also add a
"verified-by" score indicating that the changes have passed buildbot
tests)
- -1/+1: these are "soft votes". They do not have any effect on allowing
the changes to be merged or not. Do not hesitate to use them, it
allows to quicky see from the dashboard if a change was already
reviewed (the CR column at the right will show +1 or -1).
--
Adrien.
