[haiku-commits] Re: r42486 - in haiku/trunk: headers/private/kernel/platform/openfirmware src/system/boot/platform/openfirmware src/system/boot/platform/openfirmware/arch/ppc
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 26 Jul 2011 18:05:36 +0200 (MEST)
Alexander von Gluck<kallisti5@xxxxxxxxxxx> wrote:
> On Tue, 26 Jul 2011 09:25:46 +0200 (MEST), Axel Dörfler wrote:
> > kallisti5@xxxxxxxxxxx wrote:
> >> Log:
> >> * Move platform support.cpp into less generic of_support.cpp
> >> * Add header file to support of_support.cpp
> > You're already in a openfirmware/ folder, so that change feels pretty
> > redundant.
> true.. I was just afraid of calling a support.h somewhere else as its a
> pretty generic header name.
Even if that would be the case, including it with "" should be safe in our
build system.
> > Coding style: addressSize is not a type name (please use uppercase
> > type names). '{' belongs to the previous line!
> The curly brace placement was already fixed in r42489.. see? I'm
> *starting* to get ahead of you on these things. :-)
Even more ahead would be not doing them in the first place, of course ;-)
> Will fix addressSize to AddressSize
An even better name IMO would be AddressType.
Bye,
Axel.
Other related posts:
