[haiku-commits] Re: r42486 - in haiku/trunk: headers/private/kernel/platform/openfirmware src/system/boot/platform/openfirmware src/system/boot/platform/openfirmware/arch/ppc

  • From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Tue, 26 Jul 2011 09:26:11 -0500

On Tue, 26 Jul 2011 09:25:46 +0200 (MEST), Axel Dörfler wrote:
kallisti5@xxxxxxxxxxx wrote:
* Move platform support.cpp into less generic of_support.cpp
* Add header file to support of_support.cpp

You're already in a openfirmware/ folder, so that change feels pretty

true.. I was just afraid of calling a support.h somewhere else as its a
pretty generic header name.

+template<typename addressSize>
+struct of_region
+       addressSize base;
+       uint32 size;

Coding style: addressSize is not a type name (please use uppercase
type names). '{' belongs to the previous line!

The curly brace placement was already fixed in r42489.. see? I'm *starting*
to get ahead of you on these things. :-)

Will fix addressSize to AddressSize

@@ -17,6 +17,7 @@
 #include <arch_mmu.h>
 #include <kernel.h>

+#include "of_support.h"

 // set protection to WIMGNPP: -----PP

Coding style: blank lines.

Missed that one... will fix.

+       /* Memory base addresses are provided in 32 or 64 bit flavors
+ #address-cells and #size-cells matches the number of 32-bit 'cells'
+          representing the length of the base address and size fields
+       */

Prefer C++ comments.

Oh-kay, will fix.

+ dprintf("Unsupported cell size detected. (machine is > 64bit?).\n");

Hm, that useless assumption could rather be replaced by a dump of the
values :-)

Yeah... 93 - 99 could be consolidated.  Will do.

 -- Alex

Other related posts: