[haiku-commits] Re: r41412 - haiku/trunk/src/preferences/network
- From: John Scipione <jscipione@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 11 May 2011 14:13:30 -0400
>
> > Network_Preferences_bad_interface_no_crash_2.diff puts
> > the check
> > if settings is NULL in _ShowConfiguration() explicitly. I tested it
> > and the
> > patch behaves identically. Axel, does this patch look better to you?
>
> Yes, it does, though I mostly wanted to mention it, as it's really a
> small thing :-)
> Thanks anyway! Unless someone beats me to it, I'll apply it in the near
> future.
>
> Bye,
> Axel.
I think that it should throw an exception in _ShowConfiguration() or
something instead of just returning but I'll leave that up to someone more
familiar with the code of this preflet. Otherwise the patch works and fixes
the crash. The resulting preference window with nothing filled out is less
than ideal. At the very least it should indicate that no network adapter was
found. If someone wants to do the work of making the network preflet better
than I would not be opposed to it. However, my goal was to simply make the
thing not crash which is done.
Thanks for your comments Axel,
John Scipione (aka Skipp_OSX)
Other related posts:
