[haiku-commits] Re: r41412 - haiku/trunk/src/preferences/network
- From: John Scipione <jscipione@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 10 May 2011 16:09:14 -0400
On Tue, May 10, 2011 at 3:24 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>wrote:
> kallisti5@xxxxxxxxxxx wrote:
> > // display settigs of first adapter on startup
> > - _ShowConfiguration(fSettings.ItemAt(0));
> > + if (fSettings.ItemAt(0))
> > + _ShowConfiguration(fSettings.ItemAt(0));
>
> ... != NULL should be used instead, but I think it would be nicer to move
> this check to _ShowConfiguration(), anyway.
>
> Bye,
> Axel.
>
For such a little change it isn't worth defending but != NULL is
superfluous. It could be put in but it doesn't really add much. Also, why
call the _ShowConfiguration method only to just return right away? Better to
fail early.
As I understand it the Network Prefs dialog is going to be replaced soon
anyway. This is a bandaid on a limb slated for amputation.
Thank you,
John Scipione
Other related posts:
