[haiku-commits] Re: r40917 - haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn

  • From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 11 Mar 2011 16:38:15 -0600

On Fri, 11 Mar 2011 22:30:26 +0100
"Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:

> kallisti5@xxxxxxxxxxx wrote:
> > Log:
> > implement *basic* network interface Healing action; make 
> > fNetworkInterface
> > a pointer so it actually works right
> Maybe it's just me, but "healing" isn't quite the word I would use 
> here, the interface is neither sick nor hurt, anyway.

Yeah.. Heal is one of my last choices.  Repair associated with a
network interface may be patented by Redmond and Renegotiate is pretty
long for a button... definitely open to suggestions to change though

> Besides that it only matters for DHCP interfaces (not sure where you 
> placed the button, it sounds like it is on the interfaces overview,
> but it really doesn't belong there IMO)

I disagree that it doesn't belong on the interfaces overview,
triggering a re-negotiation of the network address is a useful
troubleshooting step and implementing it the overall interface makes it
easy to use/find...


> why not simply call it after
> what it does, eg. "Reconfigure now", or "Update address now"?

I didn't mention 'configure' in any form in that button because there
is already an option to 'configure' the interface.  configure next to
reconfigure may be kind of confusing.  'Renegotiate' sounds better to

> Also, why do you remove the default route manually? That should be
> done automatically during auto configure, and nothing you need to
> care about.

I thought the auto configuration is supposed to reconfigure everything..
was just thinking it may be a nice troubleshooting step.

I agree though as long as auto configure does already does this.
I will remove the RemoveDefaultRoute call.

Thanks for the input!  This kind of discussion really helps me stay on
track with what the community wants.

 -- Alex

Other related posts: