[haiku-commits] Re: r40917 - haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 11 Mar 2011 22:30:26 +0100

kallisti5@xxxxxxxxxxx wrote:
> Log:
> implement *basic* network interface Healing action; make 
> fNetworkInterface
> a pointer so it actually works right

Maybe it's just me, but "healing" isn't quite the word I would use 
here, the interface is neither sick nor hurt, anyway.
Besides that it only matters for DHCP interfaces (not sure where you 
placed the button, it sounds like it is on the interfaces overview, but 
it really doesn't belong there IMO), why not simply call it after what 
it does, eg. "Reconfigure now", or "Update address now"?

Also, why do you remove the default route manually? That should be done 
automatically during auto configure, and nothing you need to care about.


Other related posts: