[haiku-commits] Re: r40570 - in haiku/trunk: headers/os/mail headers/private/mail src/add-ons/mail_daemon/outbound_protocols/smtp src/kits/mail
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 20 Feb 2011 16:28:46 +0100
> Log:
> Copy sent mails to /boot/home/mail/sent. Hope that makes more clear if
> a
> mail should be send (in out folder) or already has be sent.
This only really renames the default folder, but doesn't imply any
actual change, does it? I mean, you can still use a single folder for
that, right?
> +#define kDefaultSentDirectory "/boot/home/mail/sent"
Please don't hardcode a path in new code, even a default path should be
built from the current user's home directory!
> +++ haiku/trunk/src/kits/mail/HaikuMailFormatFilter.cpp 2011-02-20
> 03:54:28 UTC (rev 40570)
> @@ -54,6 +54,7 @@
> fAccountId(settings->AccountID())
> {
> const BMessage* outboundSettings = &settings->OutboundSettings().
> Settings();
> + fOutboundDirectory = kDefaultSentDirectory;
> outboundSettings->FindString("destination", &fOutboundDirectory);
Besides that I think "HaikuMailFormatFilter" is not the best name
choice, the above line has no effect; the message Find*() methods are
unfortunately destructive even if they fail.
Bye,
Axel.
Other related posts:
