[haiku-commits] Re: r40149 - haiku/trunk/src/apps/bootmanager
- From: Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 9 Jan 2011 15:49:51 +0100
Am 09.01.2011 um 13:30 schrieb Axel Dörfler:
> Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx> wrote:
>> Confirmed, the problems are fixed. Thank you.
>
> Thanks!
>
>> I think it is problematic that you can now generate invalid
>> boot menus with Boot Manager, because it allows you
>> to select partitions from different drivers (before your changes
>> only partitions from the first drive could be selected).
>> Booting from a partition on another than the boot drive won't
>> work until B_GET_BIOS_DRIVE_ID is implemented.
>
> I think you misunderstood, or maybe I have messed up something. In any
> case, since B_GET_BIOS_DRIVE_ID should currently fail, only the
> partitions from the target volume are added to the menu. And I can at
> least confirm that it does work this way on my test machines.
>
> Did you actually experience this problem, or were you just confused by
> my earlier explanations? :-)
Neither ;) I tested it on VMWare with two virtual drivers and
didn't look close enough to see that Boot Manager actually only
showed the partitions from one driver.
Sorry about the noise.
> In any case, I liked the code quality in BootManager, I think you did a
> good job there.
Thank you.
- Michael
Other related posts:
