[haiku-commits] Re: r40149 - haiku/trunk/src/apps/bootmanager

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 09 Jan 2011 13:30:31 +0100

Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx> wrote:
> Confirmed, the problems are fixed. Thank you.


> I think it is problematic that you can now generate invalid 
> boot menus with Boot Manager, because it allows you
> to select partitions from different drivers (before your changes
> only partitions from the first drive could be selected).
> Booting from a partition on another than the boot drive won't
> work until B_GET_BIOS_DRIVE_ID is implemented.

I think you misunderstood, or maybe I have messed up something. In any 
case, since B_GET_BIOS_DRIVE_ID should currently fail, only the 
partitions from the target volume are added to the menu. And I can at 
least confirm that it does work this way on my test machines.

Did you actually experience this problem, or were you just confused by 
my earlier explanations? :-)

In any case, I liked the code quality in BootManager, I think you did a 
good job there.


Other related posts: