[haiku-commits] Re: r39105 - haiku/trunk/src/apps/showimage
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 24 Oct 2010 22:32:57 +0200 (MEST)
Simon Taylor<simontaylor1@xxxxxxxxxxxx> wrote:
> I remember years ago complaining when some of the extra functionality
> was added to ShowImage (which is always something that's hard to do as
> someone has obviously spent time and effort doing the implementation),
Definitely. It's also hard to say to a patch ready to be committed: no, we
don't want this.
We should always try to keep our applications as clean as possible. That
doesn't mean they can be feature rich, it just means they shouldn't have
functionality that either does not fit their purpose (ShowImage is an image
viewer, not an editor), or that just duplicates functionality (WonderBrush is
actually part of every release, and is a real image editor).
> A toolbar would probably be welcome anyway, with buttons for rotation of
> images and navigation through multiple image files along with the
> hand/select mode toggle. Otherwise just an entry in the edit menu to
> switch modes would be fine, and some entry in the documentation to say
> selections can be made in "hand" mode with either a different mouse
> button or by holding a modifier.
That was pretty much my plan after DarkWyrm's critic. Since I don't want to
spend that much time on ShowImage, and I personally don't need to see a tool
bar when I use an image viewer, a menu item is a good solution (and would be
needed anyway later on, too).
Bye,
Axel.
Other related posts:
