[haiku-commits] Re: r35433 - in haiku/trunk: headers/os/opengl headers/private/app headers/private/graphics/intel_extreme headers/private/media headers/private/screen_saver ...
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 04 Mar 2010 10:23:52 +0100
On 2010-02-14 at 12:04:53 [+0100], Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 2010-02-08 at 23:50:38 [+0100], aljen-mlists@xxxxx wrote:
> > Author: aljen
> > Date: 2010-02-08 23:50:38 +0100 (Mon, 08 Feb 2010)
> > New Revision: 35433
> > Changeset: http://dev.haiku-os.org/changeset/35433/haiku
> [...]
> > Modified: haiku/trunk/src/add-ons/kernel/drivers/tty/tty.cpp
> > ===================================================================
> > --- haiku/trunk/src/add-ons/kernel/drivers/tty/tty.cpp 2010-02-08
> > 20:39:52 UTC (rev 35432)
> > +++ haiku/trunk/src/add-ons/kernel/drivers/tty/tty.cpp 2010-02-08
> > 22:50:38 UTC (rev 35433)
> > @@ -104,6 +104,8 @@
> > {
> > }
> >
> > + virtual ~AbstractLocker() {}
> > +
>
> No runtime polymorphism or deletion of base class objects here. Please
> revert.
>
> > Modified:
> > haiku/trunk/src/add-ons/kernel/partitioning_systems/efi/PartitionLocker.h
> > ===================================================================
> > ---
> > haiku/trunk/src/add-ons/kernel/partitioning_systems/efi/PartitionLocker.h
> > 2010-02-08 20:39:52 UTC (rev 35432)
> > +++
> > haiku/trunk/src/add-ons/kernel/partitioning_systems/efi/PartitionLocker.h
> > 2010-02-08 22:50:38 UTC (rev 35433)
> > @@ -21,7 +21,7 @@
> > class PartitionLocker {
> > public:
> > PartitionLocker(partition_id partitionID);
> > - ~PartitionLocker();
> > + virtual ~PartitionLocker();
> >
> > bool IsLocked() const;
> > partition_id PartitionId() const;
> >
> > Modified:
> > haiku/trunk/src/add-ons/kernel/partitioning_systems/intel/PartitionLocker.
> > h
> > ===================================================================
> > ---
> > haiku/trunk/src/add-ons/kernel/partitioning_systems/intel/PartitionLocker.
> > h
> > 2010-02-08 20:39:52 UTC (rev 35432)
> > +++
> > haiku/trunk/src/add-ons/kernel/partitioning_systems/intel/PartitionLocker.
> > h
> > 2010-02-08 22:50:38 UTC (rev 35433)
> > @@ -21,7 +21,7 @@
> > class PartitionLocker {
> > public:
> > PartitionLocker(partition_id partitionID);
> > - ~PartitionLocker();
> > + virtual ~PartitionLocker();
> >
> > bool IsLocked() const;
> > partition_id PartitionId() const;
>
> Same here.
Reverted all the above in r35758.
> > Modified: haiku/trunk/src/kits/storage/Statable.cpp
> > ===================================================================
> > --- haiku/trunk/src/kits/storage/Statable.cpp 2010-02-08 20:39:52 UTC
> > (rev 35432)
> > +++ haiku/trunk/src/kits/storage/Statable.cpp 2010-02-08 22:50:38 UTC
> > (rev 35433)
> > @@ -41,7 +41,7 @@
> > };
> >
> >
> > -#if __GNUC__ > 2
> > +#if __GNUC__ > 3
> > BStatable::~BStatable()
> > {
> > }
>
> Is there a particular reason for that? We don't explicitly support gcc 3
> anymore, but in principle binary compatibility is only relevant for gcc 2.
*ping*
CU, Ingo
Other related posts:
