[haiku-commits] Re: r35757 - haiku/trunk/src/add-ons/kernel/partitioning_systems/intel

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 04 Mar 2010 13:08:49 +0100

On 2010-03-04 at 10:20:31 [+0100], Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 2010-03-04 at 10:53:32 [+0100], superstippi@xxxxxx wrote:
> > Author: stippi
> > Date: 2010-03-04 10:53:32 +0100 (Thu, 04 Mar 2010)
> > New Revision: 35757
> > Changeset: http://dev.haiku-os.org/changeset/35757/haiku
> > 
> > Modified:
> >    haiku/trunk/src/add-ons/kernel/partitioning_systems/intel/PartitionMap.
> >    cp
> >    p
> > Log:
> > I don't know what recent change may have caused this, but I had to
> > introduce the
> > check to avoid a division by zero when scanning my partition map in order
> > to be
> > able to boot. I cannot spot any regressions, I can still access all my
> > partitions
> > just fine.
> Michael played with the block size in r35664, but the diff looks
> inconspicious in this regard.
> BTW, generally I'm not very fond of the development strategy to apply fixes
> before understanding a problem.

Basically, I just wanted to be able to boot Haiku after upgrading. Instead of 
just applying the fix locally, I thought it's better to commit it, so that 
whoever has a clue what change may have caused this -- either who worked on 
it last or who has an understanding of the code -- is becomming aware of the 
problem. I know it would be nice if I digged into the code to understand 
what's happening, but chances are I would waste precious time, while the 
effect of me commiting the quick fix *could* make somebody else go "yes, of 
course!"... What's so bad about commiting a two line fix if the worst that 
can happen is that nobody else cares? It's not like I redesigned some crucial 
component under some wrong assumption.

Best regards,

Other related posts: