hrev54365 adds 1 changeset to branch 'master'
old head: 1487a2423852160b784be216896e5ce9770e6e20
new head: 6b3cfabfd4173fe77325642abc3c051f902e75cd
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=6b3cfabfd417+%5E1487a2423852
----------------------------------------------------------------------------
6b3cfabfd417: libnetapi: Fix if condition
Fix length[0] != '+' could not be checked.
Pointed out by cppcheck.
Change-Id: Ic4697dc9ffd04afcd92ef3ed65485e1fe3f32e76
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2950
Reviewed-by: leorize <leorize+oss@xxxxxxxxxxx>
Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev54365
Commit: 6b3cfabfd4173fe77325642abc3c051f902e75cd
URL: https://git.haiku-os.org/haiku/commit/?id=6b3cfabfd417
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Wed Jun 24 22:04:10 2020 UTC
Committer: waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Fri Jun 26 23:50:53 2020 UTC
----------------------------------------------------------------------------
1 file changed, 1 insertion(+), 1 deletion(-)
src/kits/network/libnetapi/HttpResult.cpp | 2 +-
----------------------------------------------------------------------------
diff --git a/src/kits/network/libnetapi/HttpResult.cpp
b/src/kits/network/libnetapi/HttpResult.cpp
index aee7c34032..41aa4fba87 100644
--- a/src/kits/network/libnetapi/HttpResult.cpp
+++ b/src/kits/network/libnetapi/HttpResult.cpp
@@ -99,7 +99,7 @@ BHttpResult::Length() const
*
* We can check length[0] directly because header values are trimmed by
* HttpHeader beforehand. */
- if (length[0] != '-' || length[0] != '+') {
+ if (length[0] != '-' && length[0] != '+') {
errno = 0;
char *endptr = NULL;
result = strtoul(length, &endptr, 10);
