From Murai Takashi <tmurai01@xxxxxxxxx>:
Murai Takashi has uploaded this change for review. (
https://review.haiku-os.org/c/haiku/+/2954 ;)
Change subject: file_systems/fat: Fix usage of sizeof()
......................................................................
file_systems/fat: Fix usage of sizeof()
Fix suspicious usage of 'sizeof' with a numeric constant
as parameter.
Pointed out by cppcheck.
Change-Id: Icf43843bb92b3db0634c20ddce38e2fe1099c552
---
M src/add-ons/kernel/file_systems/fat/mkdos.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://git.haiku-os.org:22/haiku refs/changes/54/2954/1
diff --git a/src/add-ons/kernel/file_systems/fat/mkdos.cpp
b/src/add-ons/kernel/file_systems/fat/mkdos.cpp
index 11fca99..944ecdb 100644
--- a/src/add-ons/kernel/file_systems/fat/mkdos.cpp
+++ b/src/add-ons/kernel/file_systems/fat/mkdos.cpp
@@ -635,7 +635,7 @@
char bootsector[512];
memset(bootsector,0x00,512);
- if (write_pos(fd, 512, bootsector, sizeof(512)) < 0)
+ if (write_pos(fd, 512, bootsector, sizeof(bootsector)) < 0)
return errno;
update_disk_device_job_progress(job, 1.0);
--
To view, visit https://review.haiku-os.org/c/haiku/+/2954
To unsubscribe, or for help writing mail filters, visit
https://review.haiku-os.org/settings
Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Icf43843bb92b3db0634c20ddce38e2fe1099c552
Gerrit-Change-Number: 2954
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange
