[haiku-commits] haiku: hrev54319 - src/apps/expander

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 11 Jun 2020 10:52:43 -0400 (EDT)

hrev54319 adds 1 changeset to branch 'master'
old head: bb6b48a9c3013e72ad79788692aba2ecb0423c1e
new head: 7a01e91863907a9c7510dd12214b47fa6900c3ed
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=7a01e9186390+%5Ebb6b48a9c301

----------------------------------------------------------------------------

7a01e9186390: Expander: prevent "Show Contents" checkbox shift 1px
  
  Relocate ExpanderWindow ScrollView outside of vertical LayoutGroup to
  prevent show/hide from shifting the LayoutGroup.
  
  Fixes #15692
  
  Change-Id: Ie6cb58a78b07ff74e890e475e7cce359dd93b21e
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/2899
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>

                               [ Bailey Carlson <bailey@xxxxxxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev54319
Commit:      7a01e91863907a9c7510dd12214b47fa6900c3ed
URL:         https://git.haiku-os.org/haiku/commit/?id=7a01e9186390
Author:      Bailey Carlson <bailey@xxxxxxxxxxxxxxxxx>
Date:        Wed Jun 10 03:16:41 2020 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Thu Jun 11 14:52:40 2020 UTC

Ticket:      https://dev.haiku-os.org/ticket/15692

----------------------------------------------------------------------------

1 file changed, 2 insertions(+), 2 deletions(-)
src/apps/expander/ExpanderWindow.cpp | 4 ++--

----------------------------------------------------------------------------

diff --git a/src/apps/expander/ExpanderWindow.cpp 
b/src/apps/expander/ExpanderWindow.cpp
index 8fb0054177..a128d5142e 100644
--- a/src/apps/expander/ExpanderWindow.cpp
+++ b/src/apps/expander/ExpanderWindow.cpp
@@ -152,9 +152,9 @@ ExpanderWindow::ExpanderWindow(BRect frame, const 
entry_ref* ref,
                                        .Add(fStatusView = new StatusView())
                                        .End()
                                .End()
-                       .Add(fScrollView)
                        .SetInsets(B_USE_WINDOW_SPACING)
-                       .End();
+                       .End()
+               .Add(fScrollView);
 
        pathLayout->SetExplicitMaxSize(BSize(B_SIZE_UNLIMITED, B_SIZE_UNSET));
        size = GetLayout()->View()->PreferredSize();


Other related posts:

  • » [haiku-commits] haiku: hrev54319 - src/apps/expander - waddlesplash