[haiku-commits] Change in haiku[master]: Teammonitor: Add 'Open Terminal' button

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 12 Jun 2020 06:03:14 +0000

From humdinger <humdingerb@xxxxxxxxx>:

humdinger has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2906 ;)


Change subject: Teammonitor: Add 'Open Terminal' button
......................................................................

Teammonitor: Add 'Open Terminal' button

* Add a button to open a Terminal to the left of the Cancel button.
  The ALT+OPT+T combo is a bit hidden, as mentioned in #16243.

* After opening a Terminal, close the Team Monitor. Being a modal
  window, the user would have to close it manually anyway to be able
  to use the Terminal.

* Remove the unneeded instructions how to use the Quit and Kill buttons.
  Now the info view can be 3 lines less tall.

* Put some weight on the scroll view, so it's the only view getting
  taller when vertically resize the window.
---
M src/add-ons/input_server/devices/keyboard/TeamMonitorWindow.cpp
1 file changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/06/2906/1

diff --git a/src/add-ons/input_server/devices/keyboard/TeamMonitorWindow.cpp 
b/src/add-ons/input_server/devices/keyboard/TeamMonitorWindow.cpp
index 22c90d3..abe3ee7 100644
--- a/src/add-ons/input_server/devices/keyboard/TeamMonitorWindow.cpp
+++ b/src/add-ons/input_server/devices/keyboard/TeamMonitorWindow.cpp
@@ -188,12 +188,15 @@
        fRestartButton = new BButton("restart", B_TRANSLATE("Restart the 
desktop"),
                new BMessage(TM_RESTART_DESKTOP));

+       BButton* openTerminal = new BButton("terminal",
+               B_TRANSLATE("Open Terminal"), new BMessage(kMsgLaunchTerminal));
+
        fCancelButton = new BButton("cancel", B_TRANSLATE("Cancel"),
                new BMessage(TM_CANCEL));
        SetDefaultButton(fCancelButton);

        BGroupLayoutBuilder(layout)
-               .Add(scrollView)
+               .Add(scrollView, 10)
                .AddGroup(B_HORIZONTAL)
                        .SetInsets(0, 0, 0, 0)
                        .Add(fKillButton)
@@ -207,6 +210,7 @@
                        .AddGlue()
                        .Add(fRestartButton)
                        .AddGlue(inset)
+                       .Add(openTerminal)
                        .Add(fCancelButton);

        CenterOnScreen();
@@ -273,6 +277,7 @@

                case kMsgLaunchTerminal:
                        be_roster->Launch("application/x-vnd.Haiku-Terminal");
+                       PostMessage(B_QUIT_REQUESTED);
                        break;

                case TM_FORCE_REBOOT:
@@ -577,9 +582,6 @@
        fRebootRunner(NULL)
 {
        fInfoString = B_TRANSLATE(
-               "Select an application from the list above and click one of "
-               "the buttons 'Kill application' and 'Quit application' "
-               "in order to close it.\n\n"
                "Hold CONTROL+ALT+DELETE for %ld seconds to reboot.");

        fTeamName = new BStringView("team name", "team name");
@@ -627,7 +629,7 @@
        fLayout->AddView(teamPropertiesView);

        infoGroup->SetExplicitMinSize(BSize(StringWidth("x") * 70, 
B_SIZE_UNSET));
-       fInfoTextView->SetExplicitSize(BSize(B_SIZE_UNSET, 
be_plain_font->Size() * 7.2));
+       fInfoTextView->SetExplicitSize(BSize(B_SIZE_UNSET, 
be_plain_font->Size() * 4.2));
        fInfoTextView->MakeEditable(false);
        fInfoTextView->MakeSelectable(false);


--
To view, visit https://review.haiku-os.org/c/haiku/+/2906
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I4a58033c0ce9b36a0e714f9bdd5c5542bca30849
Gerrit-Change-Number: 2906
Gerrit-PatchSet: 1
Gerrit-Owner: humdinger <humdingerb@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Teammonitor: Add 'Open Terminal' button - Gerrit