[haiku-commits] Re: haiku: hrev52172 - in src: add-ons/kernel/file_systems/packagefs/package add-ons/kernel/file_systems/packagefs/nodes kits/package

  • From: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 6 Aug 2018 08:20:37 +0200

On Sun, Aug 05, 2018 at 06:27:22PM -0400, waddlesplash wrote:

  Fixes #10071 (at last.)

Great, thanks!

diff --git 
a/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp 
b/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
index 355c3f9b19..84cb86fced 100644
--- a/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
+++ b/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
@@ -108,8 +108,7 @@ UnpackingDirectory::AddPackageNode(PackageNode* 
packageNode, dev_t deviceID)
              = dynamic_cast<PackageDirectory*>(packageNode);
 
      PackageDirectory* other = fPackageDirectories.Head();
-     bool isNewest = other == NULL
-             || packageDirectory->ModifiedTime() > other->ModifiedTime();
+     bool isNewest = other == NULL || *packageDirectory > *other;

isNewest is not an appropriate name for this anymore, since the
comparison is not done on the date. Maybe doesOverride or something
along those lines?

-- 
Adrien.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 08-2018