On Tue, Aug 7, 2018, 2:59 PM Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
On 06.08.2018 08:20, Adrien Destugues wrote:
On Sun, Aug 05, 2018 at 06:27:22PM -0400, waddlesplash wrote:a/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
diff --git
b/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
a/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cppindex 355c3f9b19..84cb86fced 100644
---
b/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp+++
packageNode, dev_t deviceID)@@ -108,8 +108,7 @@ UnpackingDirectory::AddPackageNode(PackageNode*
other->ModifiedTime();= dynamic_cast<PackageDirectory*>(packageNode);
PackageDirectory* other = fPackageDirectories.Head();
- bool isNewest = other == NULL
- || packageDirectory->ModifiedTime() >
+ bool isNewest = other == NULL || *packageDirectory > *other;
isNewest is not an appropriate name for this anymore, since the
comparison is not done on the date. Maybe doesOverride or something
along those lines?
+1
particularly intuitive. I'd rather turn the operator into a method with
a fitting name, like HasPrecedenceOver(), HasHigherPriorityThan(), or ...