[haiku-commits] Re: haiku: hrev52172 - in src: add-ons/kernel/file_systems/packagefs/package add-ons/kernel/file_systems/packagefs/nodes kits/package

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 7 Aug 2018 15:19:09 -0400

On Tue, Aug 7, 2018, 2:59 PM Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:

On 06.08.2018 08:20, Adrien Destugues wrote:
On Sun, Aug 05, 2018 at 06:27:22PM -0400, waddlesplash wrote:
diff --git
a/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
b/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
index 355c3f9b19..84cb86fced 100644
---
a/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
+++
b/src/add-ons/kernel/file_systems/packagefs/nodes/UnpackingDirectory.cpp
@@ -108,8 +108,7 @@ UnpackingDirectory::AddPackageNode(PackageNode*
packageNode, dev_t deviceID)
             = dynamic_cast<PackageDirectory*>(packageNode);

     PackageDirectory* other = fPackageDirectories.Head();
-    bool isNewest = other == NULL
-            || packageDirectory->ModifiedTime() >
other->ModifiedTime();
+    bool isNewest = other == NULL || *packageDirectory > *other;

isNewest is not an appropriate name for this anymore, since the
comparison is not done on the date. Maybe doesOverride or something
along those lines?

+1


Already renamed to "overridesHead" last night.

Moreover, I don't think using the operator < makes reading this code
particularly intuitive. I'd rather turn the operator into a method with
a fitting name, like HasPrecedenceOver(), HasHigherPriorityThan(), or ...


Well, one advantage of operator< is that if we ever start using some
templated list that does this sorting automatically, we won't need to
modify the code.

-waddlesplash


Other related posts: