fixing the umask on the buildbots is trivial - 1 line change in the
buildbot configuration file.Please revert the hack and fix the umask on the
buildbots instead.
If we can't get such a simple change done on our buildbots, then we have a
big problem toworry about: we are using machines we don't even control to
provide our nightlies.
2017-05-28 5:58 GMT+02:00 waddlesplash <waddlesplash@xxxxxxxxx>:
On Sat, May 27, 2017 at 3:05 PM, Ingo Weinhold <ingo_weinhold@xxxxxx>
wrote:
Firstly, I don't see why the runtime loader would need executepermission.
It is not meant to be executed and AFAICT the permission isn't
checked/required anywhere.
The ticket discussion and ttcoder's testing seemed to indicate that
this solved the problem -- probably not because of the exemode
specifically, but because it sets the bits for all users, indeed.
Secondly, it isn't exactly a huge amount of work to have the package toolto
adjust the permissions of added files and directories. It means adding a
switch to the tool ("create" and "add" commands), propagating the value
the code responsible (i.e. add a flag [1] and use it), and modifying theof
code that currently just copies the permission values to adjust them [2].
If no one cares to implement a proper solution, the issue can't be that
pressing. Given that a fairly simple work-around is to build with a less
restrictive umask, I don't see a good reason to add a hack-around. Those
temporary band-aid solutions tend to stay forever, so I'm generally wary
introducing them.
I think the buildbots have a more restrictive umask, hence this
problem. I'll talk to ttcoder and see what's up on his end, and make a
note to take a closer look at this asap. Thanks for the info!
-waddlesplash
