[haiku-commits] Re: haiku: hrev51182 - in src: system/kernel/fs bin/multiuser system/runtime_loader
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 27 May 2017 21:05:25 +0200
On 27.05.2017 19:38, waddlesplash wrote:
On Sat, May 27, 2017 at 1:12 PM, Dario Casalinuovo <b.vitruvio@xxxxxxxxx> wrote:
No, read the discussion in this ml related to this ticket. Someone argued
about it being an hack so it's not acceptable.
In the long run, no, we need to refactor the build system setup so
it's not needed, which is why the ticket was left open. But for now,
it's OK.
I beg to differ.
Firstly, I don't see why the runtime loader would need execute
permission. It is not meant to be executed and AFAICT the permission
isn't checked/required anywhere.
Secondly, it isn't exactly a huge amount of work to have the package
tool adjust the permissions of added files and directories. It means
adding a switch to the tool ("create" and "add" commands), propagating
the value to the code responsible (i.e. add a flag [1] and use it), and
modifying the code that currently just copies the permission values to
adjust them [2].
If no one cares to implement a proper solution, the issue can't be that
pressing. Given that a fairly simple work-around is to build with a less
restrictive umask, I don't see a good reason to add a hack-around. Those
temporary band-aid solutions tend to stay forever, so I'm generally wary
of introducing them.
CU, Ingo
[1]
http://cgit.haiku-os.org/haiku/tree/headers/os/package/hpkg/HPKGDefs.h?id=17286dc70a81d1aa8d853a73db0b0ebe79e6ed9a#n123
[2]
http://cgit.haiku-os.org/haiku/tree/src/kits/package/hpkg/PackageWriterImpl.cpp?id=17286dc70a81d1aa8d853a73db0b0ebe79e6ed9a#n1490
Other related posts:
