[haiku-commits] Re: haiku: hrev50886 - in src: add-ons/media/media-add-ons/multi_audio kits/media/experimental
- From: Julian Harnath <julian.harnath@xxxxxxxxxxxxxx>
- To: <haiku-commits@xxxxxxxxxxxxx>
- Date: Fri, 20 Jan 2017 21:04:06 +0100
Hello,
On 20.01.2017 20:56, b.vitruvio@xxxxxxxxx wrote:
* The fBufferFreeSem is removed as it didn't make sense. It was
used to detected when the output thread should be stopped, a
boolean flag is used instead.
Since the flag you added is not an atomic, this is essentially broken.
* Avoid to allocate a BAutolocker at begin of the _OutputThread,
plain Lock/Unlock is used instead.
What's the point of this?
Don't have time right now to review the other changes...
-Julian
Other related posts:
