[haiku-commits] Re: haiku: hrev50886 - in src: add-ons/media/media-add-ons/multi_audio kits/media/experimental
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 20 Jan 2017 23:18:46 +0100
Am 20/01/2017 um 23:02 schrieb Dario Casalinuovo:
> Yes, the semaphore is not needed at this place, and it's a good idea
> and a good optimization to remove it.
Why asking to remove a "bogus" commit then?
Because you didn't do that correctly, maybe?
I've been going to commit a patch to fix both issues BTW, but as long as
it works that way...
Fixes are always welcome, commits that potentially break things, and
make code worse aren't. Revert, fix, recommit -- if you can fix it
quickly, you can save the revert.
Bye,
Axel.
Other related posts:
