[haiku-commits] Re: haiku: hrev50183 - src/servers/media src/kits/media headers/private/media headers/os/media
- From: Jérôme Duval <jerome.duval@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 4 Apr 2016 12:04:34 +0200
2016-04-04 1:29 GMT+02:00 <b.vitruvio@xxxxxxxxx>:
diff --git a/src/servers/media/Jamfile b/src/servers/media/Jamfile
index c5edb71..aa638ee 100644
--- a/src/servers/media/Jamfile
+++ b/src/servers/media/Jamfile
@@ -2,7 +2,7 @@ SubDir HAIKU_TOP src servers media ;
SetSubDirSupportedPlatformsBeOSCompatible ;
-UsePrivateHeaders media shared storage ;
+UsePrivateHeaders media shared storage app ;
This should be ordered alphabetically.
diff --git a/src/servers/media/media_server.cpp
b/src/servers/media/media_server.cpp
index f4d7dd6..9ed51d5 100644
--- a/src/servers/media/media_server.cpp
+++ b/src/servers/media/media_server.cpp
@@ -37,7 +37,7 @@ char __dont_remove_copyright_from_binary[] = "Copyright (c)
2002, 2003 "
#include <string.h>
#include <Alert.h>
-#include <Application.h>
+#include <Server.h>
#include <Autolock.h>
#include <Directory.h>
#include <Roster.h>
This should be ordered alphabetically.
SyncToServices seems like something we want implemented as media
notifications [1]
Maybe you just overlooked the TODO right after where you added a
SyncToServices() call [2]
And besides, in case of no audio output available, it looks like the
SyncToServices() call would lock forever, or I miss something.
Bye
Jérôme
[1]
https://www.haiku-os.org/legacy-docs/bebook/TheMediaKit_MessageConstants.html
[2]
http://cgit.haiku-os.org/haiku/tree/src/kits/media/MediaRoster.cpp?id=53c3fa513774538d62d125eaf293477452fc76c9#n3474
Other related posts:
