[haiku-commits] Re: haiku: hrev50183 - src/servers/media src/kits/media headers/private/media headers/os/media
- From: Jérôme Duval <jerome.duval@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 4 Apr 2016 17:33:53 +0200
2016-04-04 15:39 GMT+02:00 Dario Casalinuovo <b.vitruvio@xxxxxxxxx>:
SyncToServices seems like something we want implemented as media
Maybe you just overlooked the TODO right after where you added a
SyncToServices() call 
I've added it myself, I've been planning to add something like that since
then but the idea was to don't make it public.
Difficult to understand what you're aiming at then. Adding a TODO and
implementing a functionality to sync with media services is confusing.
And besides, in case of no audio output available, it looks like the
SyncToServices() call would lock forever, or I miss something.
The function allow to specify a timeout, it made sense to me to implement it
Well, you should really consider to call it with a timeout value. When
DefaultManager::fMixerConnected nevers gets true, the media roster
thread would wait forever.
For good measure, AppManager::UnlockGlobalSynchro() should also reset
fGlobalSynchro after deleting it.
Other related posts: