[haiku-commits] Re: haiku: hrev50109 - src/system/kernel/platform/u-boot headers/private/kernel/platform/u-boot src/system/boot/loader

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 28 Feb 2016 12:37:53 +0100

On 02/26/2016 11:03 PM, revol@xxxxxxx wrote:

+++ b/headers/private/kernel/platform/u-boot/fdt_support.h
@@ -16,7 +16,7 @@ void dump_fdt(const void *fdt);
  status_t fdt_get_cell_count(const void* fdt, int node,
        int32 &addressCells, int32 &sizeCells);

-phys_addr_t fdt_get_device_reg(const void* fdt, int node);
+phys_addr_t fdt_get_device_reg(const void* fdt, int node, bool physical=true);

That would be "bool physical = true" (ie. missing spaces).

        // TODO: check for virtual-reg, and don't -= fdt_get_range_offset?

+       // XXX: not sure #address-cells & #size-cells actually apply to 
virtual-reg

Please use TODO instead of XXX; at least that's what everybody else uses, and it shouldn't be missed just because of that.

Bye,
   Axel.


Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 02-2016