[haiku-commits] Re: haiku: hrev50109 - src/system/kernel/platform/u-boot headers/private/kernel/platform/u-boot src/system/boot/loader

  • From: François Revol <revol@xxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 4 Mar 2016 22:30:38 +0100

On 04/03/2016 19:32, Axel Dörfler wrote:

Am 04/03/2016 um 18:14 schrieb François Revol:
On 28/02/2016 12:37, Axel Dörfler wrote:
       // TODO: check for virtual-reg, and don't -=
fdt_get_range_offset?

+    // XXX: not sure #address-cells & #size-cells actually apply to
virtual-reg
Please use TODO instead of XXX; at least that's what everybody else
uses, and it shouldn't be missed just because of that.
Well there is a little semantic difference though.

But then you're using it wrong - if it's there to mark dirty code that
requires attention, you'd have to put it everywhere in your code ;-)

It's more of a "works for me™ but I don't know how it'd work elsewhere".
I didn't see any other FDT using it yet, so...


François.


Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 03-2016