[haiku-commits] Re: haiku: hrev50043 - src/servers/media_addon

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 20 Jan 2016 18:12:30 +0100

Am 20.01.2016 um 01:46 schrieb b.vitruvio@xxxxxxxxx:

hrev50043 adds 1 changeset to branch 'master'
old head: 08a65695bb4f117688eb9a008c63e66ff6a1493c
new head: c21a2c7feda5def95e3a7a91b440dc3b0cfc8ccb
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=c21a2c7feda5+%5E08a65695bb4f

----------------------------------------------------------------------------

c21a2c7feda5: SystemTimeSource: Exit loop when the port is closed

The commit-message does not seem to fit the actual change:

diff --git a/src/servers/media_addon/SystemTimeSource.cpp 
b/src/servers/media_addon/SystemTimeSource.cpp
index bac891a..2d7cc28 100644
--- a/src/servers/media_addon/SystemTimeSource.cpp
+++ b/src/servers/media_addon/SystemTimeSource.cpp
@@ -84,6 +84,6 @@ SystemTimeSource::ControlThread()
        status_t err;
        do {
                err = WaitForMessage(B_INFINITE_TIMEOUT);
-       } while (err == B_OK || err == B_ERROR);
+       } while (err != B_BAD_PORT_ID);
        TRACE("SystemTimeSource::ControlThread() exit\n");
  }

The loop would have exited with "err == B_BAD_PORT_ID" (or any other error besides B_ERROR). So what this commit changes is that the number of conditions for exiting the loop is reduced to just "err == B_BAD_PORT_ID". If this is indeed intentional, it would be nice to get an explanation in the commit message why that is so.

Best regards,
-Stephan



Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 01-2016