[haiku-commits] Re: haiku: hrev48734 - src/kits/tracker data/artwork/icons
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Tue, 27 Jan 2015 22:18:28 -0500
On Tuesday, January 27, 2015, Augustin Cavalier <waddlesplash@xxxxxxxxx>
wrote:
> On Tue, Jan 27, 2015 at 4:21 PM, <jscipione@xxxxxxxxx
> <javascript:_e(%7B%7D,'cvml','jscipione@xxxxxxxxx');>> wrote:
>
>> e7803cf1f69a: Tracker: use the Layout API wherever possible.
>>
>
> AFAICT, this does not break any functionality, and I tested against a
> large number of apps to ensure that the changes to BFilePanel didn't break
> anything.
>
I found a small mistake
-BTitleView::BTitleView(BRect frame, BPoseView* view)
+BTitleView::BTitleView(BPoseView* view)
:
- BView(frame, "TitleView", B_FOLLOW_LEFT_RIGHT, B_WILL_DRAW),
+ BView("BTitleView", B_WILL_DRAW),
fPoseView(view),
You renamed "TitleView" to "BTitleView" which will throw off messages which
are targeted at that view By name. Pretty minor but should be corrected.
Other related posts:
