[haiku-commits] Re: haiku: hrev48623 - src/preferences/network
- From: Jérôme Duval <jerome.duval@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 8 Jan 2015 18:43:20 +0100
2015-01-08 8:22 GMT+01:00 Adrien Destugues <pulkomandy@xxxxxxxxx>:
> The implicit cast from int32 to bool yields the correct result
> (B_CONTROL_OFF == 0 casts to false, B_CONTROL_ON == 1 casts to true) and
> this doesn't trigger any compiler warning.
This is nonetheless forbidden in the coding guidelines: "Always use
boolean conditions, instead of pointer/integer logic". That this
doesn't trigger any compiler warning is off my point.
@Augustin: it's already noted deprecated. GetInt32() is preferred.
https://api.haiku-os.org/classBMessage.html#a7bdf16fbe39d305420b811c0cc00dc2a
Bye,
Jérôme
Other related posts:
