[haiku-commits] Re: haiku: hrev48623 - src/preferences/network
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 8 Jan 2015 08:22:09 +0100
On Thu, Jan 08, 2015 at 12:47:48AM +0100, Jérôme Duval wrote:
> 2015-01-07 9:27 GMT+01:00 <pulkomandy@xxxxxxxxxxxxx>:
> > hrev48623 adds 1 changeset to branch 'master'
> > old head: beb9b3453b67cfada7d2817e0b75584a35798876
> > new head: d37cd1e172d83dc095ca5cbd08832861a6ce15eb
> > overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=d37cd1e+%5Ebeb9b34
> >
> > ----------------------------------------------------------------------------
> >
> > d37cd1e: Network preferences: add a checkbox to control NetworkStatus
>
> >
> > + case kMsgToggleReplicant: {
> > + _ShowReplicant(message->FindInt32("be:value"));
>
> int32 BMessage::FindInt32() is deprecated and doesn't return a boolean.
The implicit cast from int32 to bool yields the correct result
(B_CONTROL_OFF == 0 casts to false, B_CONTROL_ON == 1 casts to true) and
this doesn't trigger any compiler warning.
--
Adrien.
Other related posts:
