[haiku-commits] Re: haiku: hrev47163 - src/kits/tracker headers/private/tracker src/apps/webpositive src
- From: Stephan Aßmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 24 Apr 2014 15:06:02 +0200
Hi,
Am 24.04.2014 um 14:34 schrieb pulkomandy@xxxxxxxxxxxxx:
>
> c161ea9: WebPositive: add a bookmark bar.
>
> * This is a BMenuBar with IconMenuItems.
> * Uses node monitoring to live-update the bar as bookmarks are modified.
> * Bookmark folders are BNavMenus and can be browsed.
> * This needs some improvements, for example handling more bookmarks than
> the window width allows us to show (with an extra menu like for tabs?)
>
> Fixes #10232.
Can we please make this optional? I hate these and they are not on by default
in other browsers. There is already the bookmarks menu.
>
> +class BookmarkBar: public BMenuBar {
> +public:
> + BookmarkBar(const char* title, BHandler* target, const entry_ref*
> navDir)
> + : BMenuBar(title)
> + {
> + BEntry(navDir).GetNodeRef(&fNodeRef);
> + }
> +
> + ~BookmarkBar()
> + {
> + stop_watching(BMessenger(this));
Is this indeed working? Can you call stop_watching() with an invalid
BMessenger? For symmetry, it should happen in DetachedFromWindow(). But I don't
know if Window() is still non-NULL in DetachedFromWindow() ATM.
Best regards,
-Stephan
Other related posts:
