24 avril 2014 16:24 "John Scipione" a écrit: > On Thursday, April 24, 2014, wrote: > > >> 5328693: Move IconMenuItem.h to headers/private/tracker. >> > > > If you'd like to export this class moving it to the IK might be a better > place, private still of course. > The main problem is it inherits PositionMenuItem, which adds a few entries to the BMessagge sent when the item is invoked. This should be split to a separate class, but then it bcomes a bit more messy to use. There are other issues like IconMenuItem allowing you to set the icon size, but then failing to take that into account when rendering itself. So it needs more work, and maybe it could be merged directly into BMenuItem, as icons in menus is something that could be standard. Unless we fear there would be an abuse of it for items that don't need it (I think adding a floppy icon to a load/save menu item is more of a waste of space than an helpful thing). -- Adrien.