On Thu, 26 Jan 2012 06:10:41 +1300, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
sorry for the late reply, will fix your comments soon, thanks!
On 22.01.2012 03:56, clemens.zeidler@xxxxxxxxxxxxxx wrote:* refactor the client memory allocator class, its possible now to just clone existing client areaCan you get a bit more into detail as to what you changed?
There was a cookie, allocator pair used previously to allocate memory, this pair is replaced by an abstract AreaMemory class now . The default ClientMemory implementation uses the old ClientMemoryAllocator class to allocate and free memory. The new ClonedAreaMemory implementation just clones an existing client area.
-bool -ClientMemoryAllocator::Lock() -{ - return fLock.ReadLock(); -}How come the lock is no longer needed?
there was already a comment that the locking is currently done elsewhere, so I just cleaned it up, think its simple enough to add it again if needed later.
Missing newline before private:.+ BAutolock _(sBitmapListLock); + sBitmapList.RemoveItem(this);I haven't read the actual code, but does this also work okay with no-server-link bitmaps?
haven't checked it, also overlay bitmaps are not handled yet. They probably have to be handled separately on a server restart...
Regards,
Clemens
