On Thu, 02 Feb 2012 00:09:17 +1300, Stephan Aßmus <superstippi@xxxxxx>
wrote:
Am 01.02.2012 11:34, schrieb Clemens:
On Thu, 26 Jan 2012 06:10:41 +1300, Axel Dörfler
<axeld@xxxxxxxxxxxxxxxx> wrote:
+ BAutolock _(sBitmapListLock);
+ sBitmapList.RemoveItem(this);
I haven't read the actual code, but does this also work okay with
no-server-link bitmaps?
haven't checked it, also overlay bitmaps are not handled yet. They
probably have to be handled separately on a server restart...
If this is not properly tested, why not put it into a feature branch?
The app_server is a critical component that already worked pretty
stable at one time. As can be witnessed by the mail daemon changes,
committing unfinished and not enough tested changes to critical
components is pretty damaging and does not necessarily lead to other
developers jumping in to bring everything back to stable operation.
Even if they do they might not have enough time and meanwhile users
are affected. It appears we have too few resources for that kind of
workflow.
Since the app_server should not crash this code should never be reached
by a normal user, however, if it crashes there is a better changes now
that stuff can be rescued.
