[haiku-commits] Change in haiku[master]: userlandfs/server/fuse: Fix PVS V773

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 25 Jun 2020 10:27:12 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2947 ;)


Change subject: userlandfs/server/fuse: Fix PVS V773
......................................................................

userlandfs/server/fuse: Fix PVS V773

Fix FUSEVolume::OpenAttr() was exited
without releasing the 'cookie' pointer.

Change-Id: I8bf08268c77e1c9704227b1d4c7c94ddcc8b09a3
---
M src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/47/2947/1

diff --git 
a/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp 
b/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp
index a358c74..87538a9 100644
--- a/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp
+++ b/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp
@@ -2211,8 +2211,10 @@

        int bytesRead = fuse_fs_getxattr(fFS, path, name, cookie->Buffer(),
                attrSize);
-       if (bytesRead < 0)
+       if (bytesRead < 0) {
+               delete cookie;
                return bytesRead;
+       }

        *_cookie = cookie;


--
To view, visit https://review.haiku-os.org/c/haiku/+/2947
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I8bf08268c77e1c9704227b1d4c7c94ddcc8b09a3
Gerrit-Change-Number: 2947
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: userlandfs/server/fuse: Fix PVS V773 - Gerrit