[haiku-commits] Change in haiku[master]: kernel/arch/x86: Fix PVS V773

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 25 Jun 2020 10:31:36 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2948 ;)


Change subject: kernel/arch/x86: Fix PVS V773
......................................................................

kernel/arch/x86: Fix PVS V773

Fix choose_link_device_configurations() was exited
without releasing the 'link' pointer.

Change-Id: I1620e63779975305776ffad717cbe2c07f4e022f
---
M src/system/kernel/arch/x86/irq_routing_table.cpp
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/48/2948/1

diff --git a/src/system/kernel/arch/x86/irq_routing_table.cpp 
b/src/system/kernel/arch/x86/irq_routing_table.cpp
index 2690415..f810ed0 100644
--- a/src/system/kernel/arch/x86/irq_routing_table.cpp
+++ b/src/system/kernel/arch/x86/irq_routing_table.cpp
@@ -236,12 +236,14 @@
                        link->possible_irqs);
                if (status != B_OK) {
                        panic("failed to read possible irqs of link device");
+                       delete link;
                        return status;
                }

                status = read_current_irq(acpi, link->handle, 
link->current_irq);
                if (status != B_OK) {
                        panic("failed to read current irq of link device");
+                       delete link;
                        return status;
                }


--
To view, visit https://review.haiku-os.org/c/haiku/+/2948
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I1620e63779975305776ffad717cbe2c07f4e022f
Gerrit-Change-Number: 2948
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: kernel/arch/x86: Fix PVS V773 - Gerrit