[haiku-commits] Change in haiku[master]: Sentence casing

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 9 Jan 2021 09:47:48 +0000

From humdinger <humdingerb@xxxxxxxxx>:

humdinger has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3612 ;)


Change subject: Sentence casing
......................................................................

Sentence casing

+ avoid spaces at the end of a translatable string, as those can
easily be missed by the translators.

Change-Id: Ic41e613b44e4248529d1f68f6bab13a048e66f3e
---
M src/add-ons/network_settings/dialup/IPCPAddon.cpp
M src/apps/networkstatus/NetworkStatusView.cpp
M src/preferences/network/InterfaceAddressView.cpp
3 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/12/3612/1

diff --git a/src/add-ons/network_settings/dialup/IPCPAddon.cpp 
b/src/add-ons/network_settings/dialup/IPCPAddon.cpp
index 26d8d6a..30c4d38 100644
--- a/src/add-ons/network_settings/dialup/IPCPAddon.cpp
+++ b/src/add-ons/network_settings/dialup/IPCPAddon.cpp
@@ -30,12 +30,12 @@

 // labels
 static const char *kLabelIPCP = "TCP/IP";
-static const char *kLabelIPAddress = "IP Address: ";
+static const char *kLabelIPAddress = "IP address: ";
 static const char *kLabelPrimaryDNS = "Primary DNS: ";
 static const char *kLabelSecondaryDNS = "Secondary DNS: ";
 static const char *kLabelOptional = "(Optional)";
-static const char *kLabelExtendedOptions = "Extended Options:";
-static const char *kLabelEnabled = "Enable TCP/IP Protocol";
+static const char *kLabelExtendedOptions = "Extended options:";
+static const char *kLabelEnabled = "Enable TCP/IP protocol";

 // add-on descriptions
 static const char *kKernelModuleName = "ipcp";
diff --git a/src/apps/networkstatus/NetworkStatusView.cpp 
b/src/apps/networkstatus/NetworkStatusView.cpp
index 1b8f64d..61631f1 100644
--- a/src/apps/networkstatus/NetworkStatusView.cpp
+++ b/src/apps/networkstatus/NetworkStatusView.cpp
@@ -353,16 +353,16 @@
                networkInterface.GetAddressAt(i, address);
                switch (address.Address().Family()) {
                        case AF_INET:
-                               text << "\n" << B_TRANSLATE("IPv4 Address: ")
+                               text << "\n" << B_TRANSLATE("IPv4 address:") << 
" "
                                        << address.Address().ToString()
-                                       << "\n" << B_TRANSLATE("Broadcast: ")
+                                       << "\n" << B_TRANSLATE("Broadcast:") << 
" "
                                        << address.Broadcast().ToString()
-                                       << "\n" << B_TRANSLATE("Netmask: ")
+                                       << "\n" << B_TRANSLATE("Netmask:") << " 
"
                                        << address.Mask().ToString()
                                        << "\n";
                                break;
                        case AF_INET6:
-                               text << "\n" << B_TRANSLATE("IPv6 Address: ")
+                               text << "\n" << B_TRANSLATE("IPv6 address:") << 
" "
                                        << address.Address().ToString()
                                        << "/" << address.Mask().PrefixLength()
                                        << "\n";
diff --git a/src/preferences/network/InterfaceAddressView.cpp 
b/src/preferences/network/InterfaceAddressView.cpp
index e40ebd0..44bf8e2 100644
--- a/src/preferences/network/InterfaceAddressView.cpp
+++ b/src/preferences/network/InterfaceAddressView.cpp
@@ -76,7 +76,7 @@

        float minimumWidth = be_control_look->DefaultItemSpacing() * 15;

-       fAddressField = new IPAddressControl(fFamily, B_TRANSLATE("IP 
Address:"),
+       fAddressField = new IPAddressControl(fFamily, B_TRANSLATE("IP 
address:"),
                NULL);
        fAddressField->SetToolTip(B_TRANSLATE("Your IP address"));
        fAddressField->TextView()->SetExplicitMinSize(

--
To view, visit https://review.haiku-os.org/c/haiku/+/3612
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ic41e613b44e4248529d1f68f6bab13a048e66f3e
Gerrit-Change-Number: 3612
Gerrit-PatchSet: 1
Gerrit-Owner: humdinger <humdingerb@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Sentence casing - Gerrit